This repository was archived by the owner on Sep 1, 2026. It is now read-only.
feat(api): provide self-hosted guidance message for WorkspaceMemberLimitExceeded error - #1642
Open
tonicofonico wants to merge 2 commits into
Open
Conversation
β¦mitExceeded error
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a dedicated WorkspaceMemberLimitExceeded app error variant and ensures it maps to the corresponding error code to support clearer self-hosted guidance messaging when workspace member limits are reached. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider keeping the error message more generic and deriving deployment-specific guidance (e.g., Community Self-Hosted vs cloud) from configuration or a help link, so that this variant doesnβt hard-code environment-specific UI and product naming into a shared error type.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider keeping the error message more generic and deriving deployment-specific guidance (e.g., Community Self-Hosted vs cloud) from configuration or a help link, so that this variant doesnβt hard-code environment-specific UI and product naming into a shared error type.Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
This was referenced Aug 1, 2026
Author
|
@sourcery-ai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Description of Changes
Fixes #1641.
This PR updates the error message string for
AppError::WorkspaceMemberLimitExceeded(ErrorCode::WorkspaceMemberLimitExceeded/1027) to simplify backend error reporting.π Related Pull Requests & Issues
NEXT_PUBLIC_DISABLE_SERVER_ACTIONSoption for reverse proxy deployments.appflowy_search.π Problem & Motivation
On Community Self-Hosted deployments, member seats per workspace are limited to 1, but user onboarding is managed via Signup Settings / Whitelist (
/console/users-management?tab=settings).Previously, when member limits were hit during workspace invitation, users received a generic billing error without actionable guidance on how to enable self-hosted team access.
π οΈ Changes Included:
libs/app-error/src/lib.rs: Added explicitAppError::WorkspaceMemberLimitExceededvariant mapping cleanly toErrorCode::WorkspaceMemberLimitExceeded(1027).π§ͺ Verification:
AppError::WorkspaceMemberLimitExceededmaps cleanly toErrorCode::WorkspaceMemberLimitExceeded(1027).Summary by Sourcery
Bug Fixes: