Add Andrew's Monotone Chain convex hull algorithm - #15165
Open
Clear20-22 wants to merge 2 commits into
Open
Conversation
Clear20-22
force-pushed
the
add-monotone-chain-convex-hull
branch
from
September 2, 2026 20:48
28807c6 to
c64c1d4
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The new module is self-contained, correctly implements the monotone chain approach, and includes adequate doctest coverage plus references consistent with existing geometry modules.
Pull request overview
Adds a new computational-geometry algorithm module implementing Andrew’s Monotone Chain method for computing the 2D convex hull, consistent with the repository’s educational, doctest-driven style.
Changes:
- Introduces
geometry/monotone_chain.pyimplementingmonotone_chain()with aPointrepresentation and a cross-product orientation helper. - Adds thorough doctest examples covering empty input, duplicates, interior points, and collinear inputs.
- Documents time/space complexity and provides a Wikipedia + paper reference.
File summaries
| File | Description |
|---|---|
| geometry/monotone_chain.py | New convex hull implementation (Andrew’s Monotone Chain) with supporting Point type, orientation helper, and doctests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add Andrew's Monotone Chain algorithm for computing the 2D convex hull of a set of points in O(n log n) time.
Checklist: