refactor(@angular/build): add composite index on last_accessed in sqlite cache store - #33995
Open
clydin wants to merge 2 commits into
Open
refactor(@angular/build): add composite index on last_accessed in sqlite cache store#33995clydin wants to merge 2 commits into
clydin wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a database index (idx_cache_accessed) on the SQLite cache store to optimize queries on last_accessed and key, along with a corresponding unit test to verify its creation. The review feedback suggests wrapping the test's database operations in a try...finally block to ensure the SQLite database connection is safely closed even if an error occurs, preventing potential file locking issues.
…ite cache store Previously, the SQLite cache table had no secondary index on `last_accessed`. Cache eviction routines during `close()` required full table scans for both TTL-based pruning and LRU size-based pruning. Specifically, calculating running sizes using a window function ordered by `last_accessed DESC, key DESC` required SQLite to materialize and sort the entire table in temporary memory on every cache close. In large persistent caches, these full scans and temporary sorts introduced unnecessary CPU and I/O overhead on shutdown. A composite index `idx_cache_accessed` on `(last_accessed DESC, key DESC)` is now created on the cache table. This enables SQLite to directly seek entries older than the TTL limit using an indexed binary search and stream rows in descending access order for the window aggregate calculation without requiring an in-memory sort pass.
clydin
force-pushed
the
perf/sqlite-cache-index
branch
from
September 2, 2026 17:22
41b8750 to
29b9bff
Compare
Previously, cache eviction routines during close executed as independent autocommit transactions. In addition, the LRU size pruning query calculated running payload sizes with a window function across the entire cache table on every build, even when total database size was well below maxPayloadSize. Pruning operations in close are now wrapped in an immediate transaction to ensure atomicity and reduce transaction commit overhead. Furthermore, total database size is checked using SQLite page pragmas prior to size-based pruning, allowing the expensive window aggregate query to be skipped when the total cache size is already within limits.
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the SQLite cache table had no secondary index on
last_accessed. Cache eviction routines duringclose()required full table scans for both TTL-based pruning and LRU size-based pruning. Specifically, calculating running sizes using a window function ordered bylast_accessed DESC, key DESCrequired SQLite to materialize and sort the entire table in temporary memory on every cache close.In large persistent caches, these full scans and temporary sorts introduced unnecessary CPU and I/O overhead on shutdown.
A composite index
idx_cache_accessedon(last_accessed DESC, key DESC)is now created on the cache table. This enables SQLite to directly seek entries older than the TTL limit using an indexed binary search and stream rows in descending access order for the window aggregate calculation without requiring an in-memory sort pass.